Shared: Improve range analysis for phis at loop exits#21135
Draft
MathiasVP wants to merge 3 commits intogithub:mainfrom
Draft
Shared: Improve range analysis for phis at loop exits#21135MathiasVP wants to merge 3 commits intogithub:mainfrom
MathiasVP wants to merge 3 commits intogithub:mainfrom
Conversation
MathiasVP
changed the title
MathiasVP
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for inferring that
i <= sizeonce the loop exits in situations such as:As @aschackmull noted this conclusion is only valid when we know that
size >= 0so for now it's restricted to the case where we can infer this constraint through the type ofsize. Ideally, this should be generalized later.